This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Relayout after recalculating to ensure visibility changes are handled correctly #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @incanus to be potential reviewers. |
ivovandongen
added
⚠️ DO NOT MERGE
Closed
|
@kkaefer @brunoabinader this pr fixes the visibility issue without revering the optimisation in 9127299 A review would be welcome so we can cherry pick it into the android 4.2.0 release |
brunoabinader
approved these changes
Nov 30, 2016
There was a problem hiding this comment.
@ivovandongen test case looks sounds. This actually fixed the same issue I had with the runtime style example in our Qt demos. Awesome!
|
This also needs to be cherry-picked to the iOS release branch. /cc @boundsj |
jfirebaugh
suggested changes
Nov 30, 2016
ivovandongen
force-pushed
the
7241-visibility-changes
branch
from
9a91366
to
00cbcce
Compare
ivovandongen
changed the title
ivovandongen
force-pushed
the
7241-visibility-changes
branch
from
00cbcce
to
424c05b
Compare
|
@jfirebaugh I fixed the unit test. Not sure how to implement the same thing in a regression test: mapbox/mapbox-gl-test-suite#188 |
ivovandongen
force-pushed
the
7241-visibility-changes
branch
from
424c05b
to
f631efd
Compare
jfirebaugh
force-pushed
the
7241-visibility-changes
branch
from
f631efd
to
320e1db
Compare
This ensures that a "wait" command will always fully flush pending update flags. This was not the case with the prior conditional map.loaded() logic.
Previously, for viewport sizes less than 512 pixels in either direction, the computed size was 0.
Style::relayout uses source.baseImpl->loaded, a flag which is updated by Style::recalculate. So recalculate first, then relayout.
jfirebaugh
force-pushed
the
7241-visibility-changes
branch
from
320e1db
to
904f1a3
Compare
jfirebaugh
approved these changes
Dec 12, 2016
boundsj
added a commit
that referenced
this pull request
Dec 14, 2016
This ports #7242 commits/2d323211af54499d5c822b8e45d7415bf92112f0 to the iOS 3.4.0 release branch.
boundsj
added a commit
that referenced
this pull request
Dec 14, 2016
This ports #7242 commits/2d323211af54499d5c822b8e45d7415bf92112f0 to the iOS 3.4.0 release branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7241
Fixes #7225
Fixes #6758
Re-ordering
relayout()afterrecalculate()ensures that sources are enabled before checking if tiles need to be reloaded on them.